Release 3.6.0 to main - #307

src/assets/English.json-14-14 (1)

14-14: Clarify the consent checkbox logic.

The text "Submit anonymously (if unchecked, we will store your user id for follow-up)" is confusing. If the checkbox is unchecked, the feedback should NOT be anonymous, so saying "Submit anonymously" when unchecked is contradictory.

Consider rephrasing to make the behavior clear, such as:

• "Submit anonymously" (simpler checkbox label)
• Or: "Do not store my user ID (submit anonymously)"

src/assets/Assamese.json-57-57 (1)

57-57: Remove the trailing 'e' character.

The Assamese translation has an English letter 'e' at the end: "মাহিলি পৰিয়াল আয়e". This appears to be a typo.

🔎 Suggested fix

-        "monthlyFamilyIncome": "মাহিলি পৰিয়াল আয়e",
+        "monthlyFamilyIncome": "মাহিলি পৰিয়াল আয়",

src/assets/English.json-1757-1757 (1)

1757-1757: Align the display text with the key name.

The key name is enterTenDigitMobileNumber, but the value only says "Enter mobile number" without specifying the 10-digit requirement. Users won't know the expected format.

🔎 Suggested fix

-    "enterTenDigitMobileNumber": "Enter mobile number"
+    "enterTenDigitMobileNumber": "Enter 10-digit mobile number"

src/app/app-modules/nurse-doctor/workarea/workarea.component.ts-263-269 (1)

263-269: Add error handling and subscription cleanup for signature check.

The subscription to checkUsersignatureExist lacks error handling. If the API call fails, the user won't be informed and doctorSignatureFlag will remain false silently. Additionally, this subscription should be stored and unsubscribed in ngOnDestroy to prevent potential memory leaks.

🔎 Proposed fix

Add a class property to store the subscription:

signatureCheckSubscription!: Subscription;

Then update the subscription:

-    this.doctorService
+    this.signatureCheckSubscription = this.doctorService
       .checkUsersignatureExist(this.sessionstorage.getItem('userID'))
       .subscribe((res: any) => {
         if (res.statusCode === 200 && res.data !== null) {
           this.doctorSignatureFlag = res.data.signStatus;
         }
-      });
+      },
+      (err: any) => {
+        console.error('Error checking user signature:', err);
+      });

And clean up in ngOnDestroy:

if (this.signatureCheckSubscription) this.signatureCheckSubscription.unsubscribe();

src/app/app-modules/nurse-doctor/visit-details/chief-complaints/chief-complaints.component.html-78-80 (1)

78-80: Suspicious selectionChange event on input field.

Line 79 binds (selectionChange) to an <input> element, but selectionChange is only fired by <mat-select> components, not standard inputs. This binding has no effect. If duration validation is needed on input changes, use the existing (input) handler on line 78 or consider (blur).

🔎 Suggested fix

               formControlName="duration"
               (input)="onInputDuration(complaint)"
-              (selectionChange)="validateDuration(complaint)"
               (focus)="trackFieldInteraction('Duration')" />

src/app/app-modules/nurse-doctor/case-sheet/general-case-sheet/doctor-diagnosis-case-sheet/doctor-diagnosis-case-sheet.component.ts-439-451 (1)

439-451: Missing error handling in getUserId subscription.

If getUserId() fails (e.g., network error), the error is silently swallowed and downloadSign won't proceed. Consider adding error handling to notify or fallback gracefully.

🔎 Proposed fix

  downloadSign() {
    this.getUserId().subscribe(
      userId => {
        const userIdToUse = this.beneficiaryDetails?.tCSpecialistUserID ?? userId;
        this.doctorService.downloadSign(userIdToUse).subscribe(
          (response: any) => {
            const blob = new Blob([response], { type: response.type });
            this.showSign(blob);
          },
          (err: any) => {
            console.error('Error downloading signature:', err);
          }
        );
      },
+     (err: any) => {
+       console.error('Error getting user ID:', err);
+     }
    );
  }

src/app/app-modules/nurse-doctor/case-sheet/general-case-sheet/doctor-diagnosis-case-sheet/doctor-diagnosis-case-sheet.component.ts-33-34 (1)

33-34: Remove unused import.

The get import from 'jquery' appears to be unused in this file.

🔎 Proposed fix

-import { get } from 'jquery';
-import { map, Observable } from 'rxjs';
+import { Observable } from 'rxjs';
+import { map } from 'rxjs/operators';

src/app/app-modules/data-sync/workarea/workarea.component.ts-94-95 (1)

94-95: Remove debug statements before production release.

console.clear() is particularly problematic as it clears the developer console, hiding potentially useful debugging information from other parts of the application. The console.log(res) is also debug logging that should be removed.

🔎 Proposed fix

  getDataSYNCGroup() {
    this.dataSyncService.getDataSYNCGroup().subscribe((res: any) => {
-      console.clear();
-      console.log(res);
      if (res.statusCode === 200) {
        this.syncTableGroupList = this.createSyncActivity(res.data);
        console.log('syncTableGroupList', this.syncTableGroupList);
      }
    });
  }

src/app/app-modules/nurse-doctor/sms-notification/sms-notification.component.css-74-76 (1)

74-76: Fix the margin property override.

Line 74 sets margin-top: 10px, but line 75 immediately overrides it with margin: 0, effectively nullifying the top margin. This appears unintentional.

🔎 Proposed fix

 .sms-section .alt-phone-field {
-  margin-top: 10px;
   margin: 0;
+  margin-top: 10px;
   width: 260px;
   min-width: 180px;
 }

Alternatively, if no top margin is needed:

 .sms-section .alt-phone-field {
-  margin-top: 10px;
   margin: 0;
   width: 260px;
   min-width: 180px;
 }

Committable suggestion skipped: line range outside the PR's diff.

src/app/app.component.ts-46-46 (1)

46-46: Remove or clarify the unused trackingService injection.

The trackingService is injected in the constructor but never used anywhere in the component or its template. Either remove this unused dependency or add a comment explaining why it's instantiated at the component level.

src/app/app-modules/nurse-doctor/case-record/general-case-record/test-and-radiology/test-and-radiology.component.html-72-74 (1)

72-74: Safe navigation operator removed - potential runtime error.

Line 73 changed from component?.testResultValue to component.testResultValue, removing the safe navigation operator. If component can be null or undefined, this will cause a runtime error.

Lines 85-87 and 102-104 retain the safe navigation operator (component?.testResultUnit, component?.remarks), suggesting defensive coding is still needed.

🔎 Proposed fix

 <div *ngFor="let component of element.componentList">
-  {{ component.testResultValue }}
+  {{ component?.testResultValue }}
 </div>

src/app/app-modules/nurse-doctor/case-record/general-case-record/diagnosis/general-opd-diagnosis/general-opd-diagnosis.component.ts-180-181 (1)

180-181: Fix Prettier formatting issue causing CI failure.

The pipeline is failing due to an extra newline on line 181.

🔎 Proposed fix

   onDiagnosisInputKeyup(value: string, index: number) {
-
     const term = (value || '').trim();

src/app/app-modules/nurse-doctor/case-record/general-case-record/diagnosis/ncd-screening-diagnosis/ncd-screening-diagnosis.component.ts-262-288 (1)

262-288: Potential runaway loop in bootstrapUntilScrollable.

The tryFill function uses requestAnimationFrame recursively without a guaranteed exit when loadingMore[rowIndex] remains true. If fetchPage errors out and doesn't reset loadingMore, this could spin indefinitely consuming CPU. Consider adding a timeout or maximum retry limit to the waiting logic.

Proposed fix with retry limit

  private bootstrapUntilScrollable(rowIndex: number, panelEl: HTMLElement) {
    let fetched = 0;
+   let waitFrames = 0;
+   const MAX_WAIT_FRAMES = 60; // ~1 second at 60fps

    const tryFill = () => {
      const scrollable = panelEl.scrollHeight > panelEl.clientHeight;
      if (
        scrollable ||
        this.noMore[rowIndex] ||
        fetched >= this.BOOTSTRAP_MAX_PAGES
      )
        return;

      if (this.loadingMore[rowIndex]) {
+       if (++waitFrames > MAX_WAIT_FRAMES) return; // prevent infinite wait
        requestAnimationFrame(tryFill);
        return;
      }

+     waitFrames = 0;
      fetched++;
      this.fetchPage(rowIndex, true);

      requestAnimationFrame(tryFill);
    };

src/app/app-modules/nurse-doctor/sms-notification/sms-notification.component.ts-112-126 (1)

112-126: Missing guard for empty prescribedDrugs array.

If this.data.prescribedDrugs is empty or undefined, the loop creates an empty req_arr, and calling sendSMS([]) might produce unexpected backend behavior. Consider validating upfront or disabling the send button when there are no drugs.

Proposed fix

  sendSMS() {
    const currentServiceID = this.sessionstorage.getItem('currentServiceID');
-   if (currentServiceID !== undefined) {
+   if (currentServiceID !== undefined && this.data.prescribedDrugs?.length > 0) {
      this._smsService
        .getSMStypes(currentServiceID)
        ...
+   } else if (!this.data.prescribedDrugs?.length) {
+     this.snackBar.open('No prescribed drugs to send', 'Close', {
+       duration: 3000,
+       verticalPosition: 'top',
+     });
    }
  }

Committable suggestion skipped: line range outside the PR's diff.

src/app/app-modules/nurse-doctor/case-record/general-case-record/diagnosis/pnc-diagnosis/pnc-diagnosis.component.ts (1)

271-272: Consider adding entries before the loop for clarity.

The conditional logic inside the loop works correctly but relies on adding exactly one entry per iteration. A clearer approach would be to add all needed entries upfront:

while (provisionalDiagnosisList.length < provisionalDiagnosisDataList.length) {
  this.addProvisionalDiagnosis();
}
for (let i = 0; i < provisionalDiagnosisDataList.length; i++) {
  provisionalDiagnosisList.at(i).patchValue({...});
  // ...
}

This makes the intent explicit and removes the dependency on per-iteration additions. However, since this pattern matches the confirmatory diagnosis logic (lines 289-292) and appears to be working correctly, this refactor is optional.

src/app/app-modules/nurse-doctor/history/general-opd-history/past-history/past-history.component.html (1)

15-18: Tracking event binding follows sensible patterns.

The tracking implementation appropriately uses:

• focus events for text inputs (capturing when users begin data entry)
• selectionChange events for dropdowns (capturing selection changes)
• click events for buttons (capturing explicit actions)

This pattern is consistent and aligns with standard telemetry practices.

Also applies to: 52-54, 80-81, 99-100, 113-116, 135-138, 147-150, 191-194, 219-220, 238-239, 252-255, 274-277, 287-289

src/app/app-modules/nurse-doctor/shared/services/doctor.service.ts (1)

2907-2917: Consider URL encoding for userName to prevent issues with special characters.

If userName contains special characters (spaces, &, ?, etc.), the URL may be malformed or cause unexpected behavior. Consider using encodeURIComponent:

🔎 Proposed fix

 getUserId(userName: any) {
-  return this.http.get(environment.getUserId + userName);
+  return this.http.get(environment.getUserId + encodeURIComponent(userName));
 }

src/app/app-modules/nurse-doctor/workarea/workarea.component.ts (3)

2486-2502: Add defensive check for array length mismatch in SMSObjectCreation.

The method assumes prescribedDrugIDs array has the same length as prescriptions. If the API returns fewer IDs than expected (due to partial failures or data inconsistency), accessing prescribedDrugIDs[index] could return undefined, leading to incomplete SMS data.

🔎 Proposed defensive check

  SMSObjectCreation(
    diagnosisList: any,
    prescriptions: any,
    prescribedDrugIDs: any
  ) {
+   if (prescribedDrugIDs?.length !== prescriptions?.length) {
+     console.warn('Prescription IDs count mismatch with prescribed drugs');
+   }
    return {
      diagnosisProvided: diagnosisList?.map((d: any) => d.term).join(', '),
      prescribedDrugs: prescriptions?.map((p: any, index: number) => ({
        beneficiaryRegID: this.beneficiaryRegID,
-       prescribedDrugID: prescribedDrugIDs[index],
+       prescribedDrugID: prescribedDrugIDs?.[index],
        drugName: p.drugName,
        dosage: `${p.dose} (${p.drugStrength})`,
        frequency: p.frequency,
        noOfDays: p.duration,
      })),
    };
  }

---

2504-2518: Consider showing a success confirmation after SMS dialog closes.

The sendPrescriptionSms method navigates immediately after the dialog closes without displaying a success confirmation to the user. Other code paths show confirmationService.alert with success messages. Consider adding confirmation feedback for consistency with user expectations.

🔎 Proposed enhancement

  sendPrescriptionSms(prescriptionSmsObject: any) {
    const dialogRef = this.mdDialog.open(SmsNotificationComponent, {
      width: '900px',
      disableClose: true,
      data: prescriptionSmsObject,
    });

    dialogRef.afterClosed().subscribe(result => {
+     this.confirmationService.alert(
+       this.currentLanguageSet.alerts.info.dataSaved || 'Data saved successfully',
+       'success'
+     );
      if (this.isSpecialist) {
        this.router.navigate(['/common/tcspecialist-worklist']);
      } else {
        this.router.navigate(['/nurse-doctor/doctor-worklist']);
      }
    });
  }

---

2868-2870: Remove unused variable declaration.

The patientVisitForm variable is declared but never used in submitCovidCareDiagnosisForm. This appears to be a copy-paste artifact from other methods that do use this variable for SMS creation.

🔎 Proposed fix

  submitCovidCareDiagnosisForm() {
    if (this.checkNurseRequirements(this.patientMedicalForm)) {
      const temp = {
        beneficiaryRegID: this.beneficiaryRegID,
        benVisitID: this.visitID,
        visitCode: this.sessionstorage.getItem('visitCode'),
        providerServiceMapID: this.sessionstorage.getItem('providerServiceID'),
        createdBy: this.sessionstorage.getItem('userName'),
      };

-     const patientVisitForm = <FormGroup>(
-       this.patientMedicalForm.controls['patientCaseRecordForm']
-     );
-
      this.doctorService

src/app/app-modules/login/login.component.ts (1)

158-163: Consider removing duplicate setUserId call.

The trackingService.setUserId is called here (line 158-160) and then again inside getServicesAuthdetails (line 258), which is invoked immediately after on line 161-163. While this doesn't cause incorrect behavior, the duplicate call is redundant.

🔎 Proposed fix to remove duplicate call

                              .subscribe((userLoggedIn: any) => {
                                if (userLoggedIn.statusCode === 200) {
                                  if (userLoggedIn?.data?.previlegeObj[0]) {
                                    this.sessionstorage.setItem(
                                      'loginDataResponse',
                                      JSON.stringify(userLoggedIn.data)
                                    );
-                                    this.trackingService.setUserId(
-                                      userLoggedIn.data.userID
-                                    );
                                    this.getServicesAuthdetails(
                                      userLoggedIn.data
                                    );

src/app/app-modules/nurse-doctor/case-record/general-case-record/prescription/prescription.component.html (2)

155-156: Missing focus tracking for Unit field.

The Unit field has selectionChange tracking on line 156 but appears to be missing (focus) tracking on line 155, unlike other select fields (e.g., Dosage on lines 93-94). Consider adding focus tracking for consistency:

🔎 Suggested addition

         name="unit"
         [(ngModel)]="currentPrescription.unit"
         [disabled]="!currentPrescription.drugID"
-        
+        (focus)="trackFieldInteraction('Unit')"
         (selectionChange)="trackFieldInteraction('Unit Selection')"
         required>

---

167-172: Use named constants to replace magic number form IDs.

The quantity field is conditionally hidden for formIDs 1 and 2 across multiple prescription components. This pattern appears intentional and consistent, but the magic numbers lack explanation. Replace formID !== 1 && formID !== 2 with named constants (e.g., LIQUID_FORM_ID, INJECTION_FORM_ID) or add an inline comment explaining which form types these IDs represent—for example:

<!-- Hide quantity for liquid/injection forms (formID 1-2) -->
*ngIf="
  currentPrescription.formID &&
  currentPrescription.formID !== 1 &&
  currentPrescription.formID !== 2
"

This pattern is replicated in quick-consult.component.html and prescribe-tm-medicine.component.html and should be consistent across all three.

src/app/app-modules/data-sync/workarea/workarea.component.html (1)

102-141: Consider extracting inline styles to the component stylesheet.

The footer legend uses inline styles for flex layout and margins. While functional, moving these to workarea.component.css would improve maintainability.

src/app/app-modules/nurse-doctor/quick-consult/quick-consult.component.ts (2)

174-183: Arrays accessed by index without initialization may cause issues.

The arrays loadingMore, noMore, wantMore, pageByIndex, lastQueryByIndex, and suggestedDiagnosisList are accessed by index in methods like fetchPage, but they're initialized as empty arrays. Accessing array[index] where index hasn't been set will return undefined. While JavaScript handles this gracefully, consider initializing these per-index when first accessed or using a default value pattern.

---

1302-1328: Potential performance concern with recursive requestAnimationFrame in bootstrapUntilScrollable.

When loadingMore[rowIndex] is true, tryFill schedules itself repeatedly via requestAnimationFrame until loading completes. While bounded by BOOTSTRAP_MAX_PAGES, this creates a tight loop polling the loading state. Consider using the complete callback in fetchPage to chain the next iteration instead.

src/app/app-modules/core/services/http-service.service.ts (1)

22-24: Consider consolidating the dual HttpClient injection.

The service injects HttpClient twice with different names (_http and http). Line 32 uses this.http while line 35 uses this._http. This creates inconsistency and confusion.

Consider using a single HttpClient instance throughout:

  constructor(
-   private _http: HttpClient,
-   private http: HttpClient
+   private http: HttpClient
  ) {

Then update line 35:

  getLanguage(url: string) {
-   return this._http.get(url);
+   return this.http.get(url);
  }

Also applies to: 32-32

src/app/app-modules/nurse-doctor/sms-notification/sms-notification.component.css (1)

21-22: Remove commented-out code.

The commented border-radius properties should either be uncommented if needed or removed to keep the codebase clean.

src/app/app-modules/nurse-doctor/sms-notification/sms-notification.component.html (1)

74-74: Add validation to disable Send SMS button.

The Send SMS button is always enabled, even when an alternate number is provided but invalid. Consider disabling the button when altNum is true and the phone number is invalid to prevent erroneous submissions.

🔎 Suggested fix

-<button mat-raised-button class="send-btn" (click)="sendSMS()">
+<button mat-raised-button class="send-btn" (click)="sendSMS()" [disabled]="altNum && phnNum.invalid">
   Send SMS
 </button>

src/app/app-modules/nurse-doctor/case-record/general-case-record/findings/findings.component.ts (1)

472-474: Add error handling for tracking failures.

The trackFieldInteraction method delegates to the tracking service without error handling. If the tracking service fails, it could potentially disrupt the user experience.

🔎 Proposed fix to add defensive error handling

 trackFieldInteraction(fieldName: string) {
-  this.trackingService.trackFieldInteraction(fieldName, 'Findings');
+  try {
+    this.trackingService.trackFieldInteraction(fieldName, 'Findings');
+  } catch (error) {
+    console.error('Tracking error:', error);
+    // Fail silently to avoid disrupting user experience
+  }
 }

src/app/app-modules/nurse-doctor/visit-details/visit-details/visit-details.component.ts (1)

295-297: Add error handling for tracking failures.

Similar to other components, consider adding defensive error handling to prevent tracking failures from affecting the user experience.

🔎 Proposed fix

 trackFieldInteraction(fieldName: string) {
-  this.trackingService.trackFieldInteraction(fieldName, 'Visit Details');
+  try {
+    this.trackingService.trackFieldInteraction(fieldName, 'Visit Details');
+  } catch (error) {
+    console.error('Tracking error:', error);
+  }
 }

src/app/app-modules/nurse-doctor/examination/general-opd-examination/systemic-examination/musculoskeletal-system/musculoskeletal-system.component.ts (1)

184-189: Add error handling for tracking failures.

Consider wrapping the tracking call in try-catch to prevent exceptions from disrupting the examination workflow.

🔎 Proposed fix

 trackFieldInteraction(fieldName: string) {
-  this.trackingService.trackFieldInteraction(
-    fieldName,
-    'Musculoskeletal System Examination'
-  );
+  try {
+    this.trackingService.trackFieldInteraction(
+      fieldName,
+      'Musculoskeletal System Examination'
+    );
+  } catch (error) {
+    console.error('Tracking error:', error);
+  }
 }

src/app/app-modules/nurse-doctor/examination/general-opd-examination/systemic-examination/central-nervous-system/central-nervous-system.component.html (1)

12-12: Consider debouncing focus events for better performance.

The template adds multiple (focus) event bindings that will fire every time a user focuses on a textarea. For frequently accessed forms, this could generate substantial tracking traffic.

Consider implementing debouncing in the component to limit the frequency of tracking calls:

import { debounceTime, Subject } from 'rxjs';

private trackingSubject = new Subject<{field: string, context: string}>();

ngOnInit() {
  this.trackingSubject
    .pipe(debounceTime(300))
    .subscribe(({field, context}) => {
      this.trackingService.trackFieldInteraction(field, context);
    });
}

trackFieldInteraction(fieldName: string) {
  this.trackingSubject.next({field: fieldName, context: 'Central Nervous System Examination'});
}

Also applies to: 36-36, 54-54, 72-72, 90-90, 108-108, 122-122, 146-146

src/app/app-modules/nurse-doctor/examination/general-opd-examination/systemic-examination/systemic-examination.component.ts (1)

143-148: Add error handling for tracking failures.

Consider defensive error handling to ensure tracking issues don't affect the examination workflow.

🔎 Proposed fix

 trackFieldInteraction(fieldName: string) {
-  this.trackingService.trackFieldInteraction(
-    fieldName,
-    'Systemic Examination'
-  );
+  try {
+    this.trackingService.trackFieldInteraction(
+      fieldName,
+      'Systemic Examination'
+    );
+  } catch (error) {
+    console.error('Tracking error:', error);
+  }
 }

src/app/app-modules/core/components/app-footer/app-footer.component.html (1)

33-35: Consider improving icon accessibility.

The mail icon could benefit from an aria-label for screen readers, especially since it's part of an interactive element.

🔎 Suggested improvement

-      <mat-icon style="vertical-align: top; font-size: medium; margin-right: 2%"
-        >mail</mat-icon
-      >
+      <mat-icon 
+        style="vertical-align: top; font-size: medium; margin-right: 2%"
+        aria-label="Feedback"
+        >mail</mat-icon
+      >

src/app/app-modules/nurse-doctor/case-record/general-case-record/findings/findings.component.html (4)

126-128: Consider extracting multi-statement event handler to component method.

The optionSelected event contains three semicolon-separated method calls. For better maintainability, consider extracting this into a single component method.

🔎 Suggested refactor

In the component TypeScript file, add:

onComplaintSelected(event: any, index: number) {
  this.filterComplaints(event, index);
  this.getSCTid(event, index);
  this.trackFieldInteraction('Chief Complaint Selection');
}

Then update the template:

             <mat-autocomplete
               #auto="matAutocomplete"
               [displayWith]="displayChiefComplaint"
-              (optionSelected)="
-                filterComplaints($event, i); getSCTid($event, i); trackFieldInteraction('Chief Complaint Selection')
-              ">
+              (optionSelected)="onComplaintSelected($event, i)">

---

180-180: Consider extracting multi-statement event handler to component method.

The selectionChange event contains two semicolon-separated method calls. For better maintainability, consider extracting this into a single component method.

🔎 Suggested refactor

In the component TypeScript file, add:

onUnitOfDurationChange(complaint: any) {
  this.validateDuration(complaint);
  this.trackFieldInteraction('Unit Of Duration');
}

Then update the template:

               <mat-select
                 class="input-full-width mat_label_fix"
                 name="unitOfDuration"
                 formControlName="unitOfDuration"
                 [disabled]="!complaint.value.duration"
-                (selectionChange)="validateDuration(complaint); trackFieldInteraction('Unit Of Duration')">
+                (selectionChange)="onUnitOfDurationChange(complaint)">

---

213-213: Consider extracting multi-statement event handler to component method.

The click event contains two semicolon-separated method calls. For consistency with other refactoring suggestions, consider extracting this into a single component method.

🔎 Suggested refactor

In the component TypeScript file, add:

onRemoveComplaint(index: number, complaint: any) {
  this.removeCheifComplaint(index, complaint);
  this.trackFieldInteraction('Remove Complaint Button');
}

Then update the template:

             <button
               mat-mini-fab
               [id]="'removeBtn' + i"
               *ngIf="i !== 0 || (i === 0 && complaint.touched)"
-              (click)="removeCheifComplaint(i, complaint); trackFieldInteraction('Remove Complaint Button')"
+              (click)="onRemoveComplaint(i, complaint)"
               color="warn"
               style="margin-right: 3px"
               class="mat_warn_circle">

---

224-224: Consider extracting multi-statement event handler to component method.

The click event contains two semicolon-separated method calls. For consistency with other refactoring suggestions, consider extracting this into a single component method.

🔎 Suggested refactor

In the component TypeScript file, add:

onAddComplaint() {
  this.addCheifComplaint();
  this.trackFieldInteraction('Add Complaint Button');
}

Then update the template:

             <button
               mat-mini-fab
               [id]="'addBtn' + i"
               *ngIf="isLast"
               [disabled]="checkComplaintFormValidity(complaint)"
-              (click)="addCheifComplaint(); trackFieldInteraction('Add Complaint Button')"
+              (click)="onAddComplaint()"
               color="primary"
               class="mat_blue_circle">

src/app/app-modules/nurse-doctor/examination/general-opd-examination/general-examination/general-examination.component.ts (1)

208-208: Minor style change: type annotation removed.

The type annotation for hideForANCAndQC was removed. This is acceptable as TypeScript infers the type from the initialization, but for consistency, you may want to verify whether your team's coding guidelines prefer explicit type annotations for class properties.

src/app/app-modules/nurse-doctor/smsTemplate/sms-template.service.ts (3)

33-36: Unused dependency injection: httpIntercept is never used.

HttpServiceService is injected but all HTTP calls use HttpClient directly. Either remove the unused injection or use httpIntercept if it provides custom interceptor logic (e.g., auth headers, error handling).

🔎 Suggested fix: Remove unused injection

 export class SmsTemplateService {
   constructor(
-    private httpIntercept: HttpServiceService,
     private http: HttpClient
   ) {}

Or, if HttpServiceService wraps HttpClient with interceptors, use it instead:

 export class SmsTemplateService {
   constructor(
-    private httpIntercept: HttpServiceService,
-    private http: HttpClient
+    private http: HttpServiceService
   ) {}

---

38-49: Potential code duplication: getSMStemplates and getSMSTemplates are nearly identical.

Both methods call the same endpoint. The only difference is that getSMStemplates accepts an optional smsTypeID. Consider consolidating:

🔎 Suggested consolidation

-  getSMStemplates(providerServiceMapID: any, smsTypeID?: any) {
+  getSMStemplates(providerServiceMapID: any, smsTypeID?: any): Observable<any> {
     return this.http.post(environment.getSMStemplates_url, {
       providerServiceMapID: providerServiceMapID,
       smsTemplateTypeID: smsTypeID ? smsTypeID : undefined,
     });
   }
-
-  getSMSTemplates(providerServiceMapID: any) {
-    return this.http.post(environment.getSMStemplates_url, {
-      providerServiceMapID: providerServiceMapID,
-    });
-  }
+  // getSMSTemplates can be replaced by getSMStemplates(providerServiceMapID) without the second arg

---

56-58: Consider adding explicit return type annotations.

The service methods implicitly return Observable<any>. Adding explicit types improves maintainability and IDE support.

import { Observable } from 'rxjs';

sendSMS(obj: any): Observable<any> {
  return this.http.post(environment.sendSMS_url, obj);
}

src/app/app-modules/nurse-doctor/shared/utility/autocomplete-scroller.directive.ts (2)

57-70: Address linter warning: remove non-null assertion on line 67.

While the assertion is logically safe (assigned on line 58), the linter flags it. A minor refactor eliminates the warning.

🔎 Suggested fix

         this.ngZone.runOutsideAngular(() => {
-          this.scrollListener = () => {
+          const listener = () => {
             if (panelEl.scrollHeight <= panelEl.clientHeight) return; // no overflow yet
             const ratio =
               (panelEl.scrollTop + panelEl.clientHeight) / panelEl.scrollHeight;
             if (ratio >= this.threshold) {
               // hop back into Angular so change detection works
               this.ngZone.run(() => this.nearEnd.emit());
             }
           };
-          panelEl.addEventListener('scroll', this.scrollListener!, {
+          this.scrollListener = listener;
+          panelEl.addEventListener('scroll', listener, {
             passive: true,
           });
         });

---

95-104: Consider documenting the fallback logic for panel resolution.

The getPanelEl method uses internal Material APIs via any cast, which may break on future Angular Material updates. A brief comment helps future maintainers understand the fragility.

   private getPanelEl(): HTMLElement | null {
-    // Newer Material exposes panel element
+    // Access internal MatAutocomplete panel element.
+    // NOTE: This relies on internal Angular Material APIs and may need
+    // adjustment after Material version upgrades.
     const anyAc = this.ac as any;

src/app/app-modules/nurse-doctor/case-record/general-case-record/diagnosis/general-opd-diagnosis/general-opd-diagnosis.component.ts (1)

305-307: Consider adding user feedback for fetch errors.

Currently, errors are only logged to console. Users may not understand why results stop loading.

         error: () => {
           console.error('Error fetching diagnosis data');
+          // Optionally show a toast or set an error state
+          // this.confirmationService.alert('Failed to load diagnosis suggestions', 'error');
         },

src/app/app-modules/nurse-doctor/case-record/general-case-record/diagnosis/ncd-screening-diagnosis/ncd-screening-diagnosis.component.ts (1)

290-342: Subscription in fetchPage is not tracked for cleanup.

Each call to fetchPage creates a new subscription to masterdataService.searchDiagnosisBasedOnPageNo that is not tracked. While the stale-query guard at line 306 helps, rapid navigation or component destruction could leave dangling subscriptions.

Consider tracking active subscriptions per index and canceling them on new requests or component destruction:

+ private fetchSubs: Subscription[] = [];
  ...
  private fetchPage(index: number, append = false) {
    const term = this.lastQueryByIndex[index];
    if (!term) return;
    ...
+   this.fetchSubs[index]?.unsubscribe();
-   this.masterdataService
+   this.fetchSubs[index] = this.masterdataService
      .searchDiagnosisBasedOnPageNo(termAtReq, pageAtReq)
      .subscribe({...});
  }

src/app/app-modules/nurse-doctor/sms-notification/sms-notification.component.ts (2)

153-160: Console log in production code.

The console.log('charCode', charCode) statement on line 155 should be removed before production release.

Proposed fix

  allowOnlyNumbers(event: KeyboardEvent) {
    const charCode = event.which ? event.which : event.keyCode;
-   console.log('charCode', charCode);

    if (charCode < 48 || charCode > 57) {
      event.preventDefault();
    }
  }

---

1-15: Unused import: ViewChild and MatPaginator.

ViewChild and MatPaginator are imported but not used in the component. Remove unused imports to keep the code clean.

Proposed fix

-import { Component, Inject, ViewChild } from '@angular/core';
+import { Component, DoCheck, Inject, OnInit } from '@angular/core';
...
-import { MatPaginator } from '@angular/material/paginator';

src/app/app-modules/nurse-doctor/case-record/general-case-record/diagnosis/ncd-care-diagnosis/ncd-care-diagnosis.component.ts (2)

260-279: Same subscription cleanup concerns apply here.

As noted in the review of ncd-screening-diagnosis.component.ts, the subscriptions in fetchPage are not tracked for cleanup. Consider applying the same fix pattern to track and cancel subscriptions on component destruction or when new requests supersede old ones.

Also applies to: 342-394

---

314-340: Same bootstrapUntilScrollable loop concern applies.

The recursive requestAnimationFrame pattern has the same potential for spinning indefinitely if loadingMore never resets. Consider adding the retry limit safeguard suggested for ncd-screening-diagnosis.component.ts.